Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opentelemetry-specification version to 1.29.0 #3757

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Update opentelemetry-specification version to 1.29.0 #3757

merged 3 commits into from
Jan 11, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jan 11, 2024

Replacement for #3755 (see #3756 as well)

@svrnm svrnm requested review from a team January 11, 2024 09:51
@svrnm
Copy link
Member Author

svrnm commented Jan 11, 2024

@chalin can you take a look at this please, we might need to modify that URL checking to allow those legacy links

Run scripts/check-build-log.sh
WARNINGs or ERRORs found in build log:
WARNING: link to spec page encoded as an external URL, but should be a local path, fix this upstream;
WARNING: link to spec page encoded as an external URL, but should be a local path, fix this upstream;
WARNING: link to spec page encoded as an external URL, but should be a local path, fix this upstream;

@chalin chalin force-pushed the opentelemetrybot/auto-update-opentelemetry-specification-1.29.0 branch from 9e38d1c to 4c41a75 Compare January 11, 2024 11:55
chalin
chalin approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the check since, as the TODO message said "drop the following warning once the checks are enabled in the spec repos" and the check is now in the spec repo.

All checks are green now (and I don't know why it didn't fail before -- looking at the logs it seems that is did fail, but maybe just not noticed before the merge?).

@chalin
Copy link
Contributor

chalin commented Jan 11, 2024

All green, merging!

@chalin chalin merged commit f8a7ec7 into main Jan 11, 2024
16 checks passed
@chalin chalin deleted the opentelemetrybot/auto-update-opentelemetry-specification-1.29.0 branch January 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @chalin @opentelemetrybot